On Sun, Feb 10, 2019 at 09:46:28PM +0300, Vitaly Chikunov wrote: > > >From the other point of view, set_params may never be called or > implemented. So, making it called first and move memory zeroing > into set_params may create more complications than simplicity. > > Making both callbacks callable in any order also will not make > things simpler. (Need to be prepared to be called in different > order.) How about encoding these parameters together with the public/private keys so that they can be set through the existing setkey functions? You might want to have a look at how we handle this in crypto/dh.c. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt