On Wed, 13 Feb 2019 at 15:21, Bartosz Szczepanek <bsz@xxxxxxxxxxxx> wrote: > > On Wed, Feb 13, 2019 at 12:26 PM Jarkko Sakkinen > <jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote: > > Collides with Matthew's changes. I want to land those change first > > because they are almost production ready. > > > > Maybe you should consider reviewing those changes to make sure that > > they make sense to you so that you can build these on top of after > > these have landed. > > Yeah, I think so. Actually, I wasn't aware of Matthew's efforts, as it > didn't appear on linux-efi mailing list. (On bad, I haven't checked > linux-integrity.) > > At this point, I think it makes more sense to limit this patchset to > 5/5 patch, which makes TPM event log initialized on ARM platforms. > Patches 1-4 introduce nothing more than Matthew already did, maybe > except putting calc_tpm2_event_size to a library instead of making it > inline. This function has already grown a bit so it may be a better > approach, but that's nothing to affect functionality. > > I'll pull Matthew changes to my tree to confirm operation on ARM > platforms, if that works fine the only thing to merge would be 5/5 + > optionally the library change, if we reach agreement on that. > Sounds good, and yes, it would be good to cc patches that affect the EFI subsystem to linux-efi as well.