On Mon, Feb 11, 2019 at 12:58:21PM -0800, Matthew Garrett wrote: > > Wondering that should this function instead do right `in the beginning: > > > > if (efi.tpm_log == EFI_INVALID_TABLE_ADDR && > > efi.tpm_final_log == EFI_INVALID_TABLE_ADDR) > > return 0; > > > > Feels odd condition that the log would not be invalid but the post log > > (using post would be more self-describing than final imho) would be. Can > > that legitly happen? > > The spec name is final, so I kept it that way for consistency. Keeping > a separate check for the final event log is partly out of > defensiveness against firmware implementations getting this wrong - > I've definitely found implementations that just don't produce any > final events, so it wouldn't surprise me if there are some that don't > install the table. OK, sounds very reasonable. > Done. I'll send an updated patchset. Awesome, thank you. /Jarkko
