On 2/11/19 8:48 AM, Jarkko Sakkinen wrote: > You are missing a cover letter from this patch set. Please have it in > v2. Also use tag "selftests/tpm2" instead of having two tags in the > short summaries. Now they look a bit weird. Since when is the cover letter mandatory? I understand that is helps for a complicated patch set to explain the problem and solution in the cover letter, but for this simple test case addition what's the point? And there is nothing forcing a cover letter in https://www.kernel.org/doc/html/v4.20/process/submitting-patches.html Also double tags seams to be quite common for selftest. See git log tools/testing/selftests/ Thanks, -- Tadeusz
