On Mon, Feb 11, 2019 at 04:28:00PM +0200, Jarkko Sakkinen wrote: > On Mon, Feb 04, 2019 at 01:33:00PM -0800, Matthew Garrett wrote: > > +static inline int _calc_tpm2_event_size(struct tcg_pcr_event2_head *event, > > + struct tcg_pcr_event *event_header) > > Maybe __calc_tpm2_event_size(). Nice to have: add a kdoc since the function is now public e.g. a brief description how the event size is calculated. /Jarkko