Re: [PATCH v4 1/2] tpm: Unify the send callback behaviourä

Subject: Re: [PATCH v4 1/2] tpm: Unify the send callback behaviourä
From: Stefan Berger <stefanb@xxxxxxxxxxxxx>
Date: Fri, 8 Feb 2019 14:27:31 -0500
Cc: linux-integrity@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, Peter Huewe <PeterHuewe@xxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>, Alexander Steffen <Alexander.Steffen@xxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <20190208191710.GA30645@linux.intel.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 2/8/19 2:17 PM, Jarkko Sakkinen wrote:


  */
if (rc > 0) {
	dev_warn(&chip->dev,
		 "%s: send(): invalid value %d\n", __func__, rc);
	rc = 0;
}

Should be fairly safe play now.

Unfortuantely it isn't. You seemed to have lost theEXPORT_SYMBOL_GPL(tpm_chip_start/stop) and the tpm_chip_start/stoparound the tpm2_shutdown()...


/Jarkko

Follow-Ups:
- Re: [PATCH v4 1/2] tpm: Unify the send callback behaviourä
  - From: Jarkko Sakkinen

References:
- [PATCH v4 0/2] tpm: Unify send() callbacks
  - From: Jarkko Sakkinen
- [PATCH v4 1/2] tpm: Unify the send callback behaviour
  - From: Jarkko Sakkinen
- Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour
  - From: Stefan Berger
- Re: [PATCH v4 1/2] tpm: Unify the send callback behaviour
  - From: Jarkko Sakkinen
- Re: [PATCH v4 1/2] tpm: Unify the send callback behaviourä
  - From: Jarkko Sakkinen