Re: [PATCH v10 00/17] Remove nested TPM operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 23, 2019 at 06:59:48PM +0000, Winkler, Tomas wrote:
> > 
> > On 1/23/19 1:20 PM, Jarkko Sakkinen wrote:
> > > On Wed, Jan 16, 2019 at 11:23:25PM +0200, Jarkko Sakkinen wrote:
> > >> Make the changes necessary to detach TPM space code and TPM
> > >> activation code out of the tpm_transmit() flow because of both of
> > >> these can cause nested tpm_transmit() calls. The nesteds calls make
> > >> the whole flow hard to maintain, and thus, it is better to just fix
> > >> things now before this turns into a bigger mess.
> > > Any reasons not to merge this soon?
> > 
> > I suppose v10 hasn't changed anything signinficat. So, not from my perspective.
> > Were you waiting for more Reviewed-by's?
> > 
> I'm okay, in theory I've cleaned all my concern regarding idle and
> locality . I'm just want do few more tests on Sunday.

I'm in no rush merging this piece of code, as long as it gets merged
at some point. Thomas, can you take a look at the PTT issue we are
having.

See my discussion with Linus with subject "Getting weird TPM error after
rebasing my tree to security/next-general". You have better knowledge
of the internals so I would really like to hear your feedback on that.
We need to get a fix for that for v5.0.

/Jarkko



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux