On Mon, Jan 21, 2019 at 02:50:49PM +0100, Roberto Sassu wrote: > On 1/21/2019 1:37 PM, Jarkko Sakkinen wrote: > > 3. The would be nothing wrong exposing struct tpm_chip in > > include/linux/tpm.h. I would be totally fine with that. > > Should I do it in a separate patch (before 5/5)? Yes. > Is it fine to call tpm_default_chip() only in pcrlock() for trusted > keys? I think you should get the reference in init_trusted() (similar pattern as in IMA). /Jarkko