On Tue, Jan 22, 2019 at 02:01:59PM +0200, Jarkko Sakkinen wrote:
> On Thu, Jan 17, 2019 at 12:41:35PM -0500, Stefan Berger wrote:
> > This patch enables a user to specify the additional optional command
> > parameter by writing it into the request file:
> >
> > # echo "23 16" > request
> > # cat request
> > 23 16
> >
> > For backwards compatibility:
> >
> > If only 1 parameter is given then we assume this is the operation request
> > number.
> >
> > # echo "5" > request
> > # cat request
> > 5
> >
> > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> > Tested-by: David Safford <david.safford@xxxxxx>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
Oops, sorry, this was meant for 4/5, so please ignore that.
The goto statement in tpm_store_ppi_request() is a bit messy as you
jump between branches. Definitely works, but very unreadable.
To get around it, you could change the branching as
if (strcmp(chip->ppi_version, "1.3") == 0 &&
sscanf(buf, "%llu %llu", &tmp[0].integer.value,
&tmp[1].integer.value) == 2) {
/* ... */
} else if (strcmp(chip->ppi_version, "1.2") == 0) {
/* ... */
} else {
/* ... */
}
/Jarkko
