Please use "tpm:" tag for commits, not "tpm/eventlog/tpm1". On Fri, Jan 11, 2019 at 04:59:32PM +0800, Jia Zhang wrote: > The responsibility of tpm1_bios_measurements_start() is to walk > over the first *pos measurements, ensuring the skipped and > to-be-read measurements are not out-of-boundary. > > Current logic is complicated a bit. Just employ a do-while loop > with necessary sanity check, and then get the goal. > > Signed-off-by: Jia Zhang <zhang.jia@xxxxxxxxxxxxxxxxx> What does this fix? Even if the current logic is "complicated", it is still a pretty simple functiion. Applying clean ups for fun has the side-effect of making backporting more difficult. And swapping implementation randomly has the side-effect of potentially introducing regressions. The current code might be messy but it is still field tested. I'm sorry but I have to reject this patch. /Jarkko
