On Mon, Dec 17, 2018 at 4:14 PM Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote: > > Start the policy_tokens and the associated enumeration from zero, > simplifying the pt macro. I applied this directly, since I decided to just commit my own "don't use negative Opt_err" patch for the test_and_set_bit() cases, and they kind of go together. There's still a -1 in security/keys/encrypted-keys/encrypted.c, and there are also three cases of "Opt_error = -1" in the security layer. All of which look pointless and wrong, but not actively buggy, so I'll leave them alone. Linus