On Sat, 2018-12-01 at 06:01 +0300, Vitaly Chikunov wrote:
> On Fri, Nov 30, 2018 at 02:21:34PM -0500, Mimi Zohar wrote:
> > On Wed, 2018-11-28 at 23:06 +0300, Vitaly Chikunov wrote:
> >
> > > @@ -1773,6 +1776,7 @@ static char *get_password(void)
> > > int main(int argc, char *argv[])
> > > {
> > > int err = 0, c, lind;
> > > + ENGINE *eng = NULL;
> > >
> > > g_argv = argv;
> > > g_argc = argc;
> > > @@ -1883,6 +1887,18 @@ int main(int argc, char *argv[])
> > > case 138:
> > > measurement_list = 1;
> > > break;
> > > + case 139: /* --engine e */
> > > + eng = ENGINE_by_id(optarg);
> >
> > The usage is only adding "--engine e" support. Either change the
> > usage or add a test to verify the argument.
>
> Could you elaborate what I should do? I didn't understand your
> suggestion. User should be able to specify anything as engine name and
> it is tested by ENGINE_by_id call. Also, usage implies that it would
> load engine with the name e.
My mistake. Could you update the patch description with example
usage?
Mimi
