> On Nov 20, 2018, at 10:23 AM, H. Peter Anvin <hpa@xxxxxxxxx> wrote: > > On 11/20/18 10:18 AM, Peter Zijlstra wrote: >>> Can't we make this test in text_poke() directly, please? >> >> He does that in 9/10 iirc. > > No, in 9/10 he does that change locally for the jump_label, but there is > absolutely no reason not to do that test in text_poke() proper, and > simply use text_poke() everywhere in the kernel. The decision in __jump_label_transform() is between text_poke_early() and text_poke_bp() ( and not text_poke() ). Moveover, text_poke_early() is also used when a module is loaded - a decision which based on the “init" argument. For these two reasons, I don’t see how the change you proposed can be performed.