On Wed, Nov 14, 2018 at 04:31:02PM +0100, Roberto Sassu wrote: > This patch renames active_banks (member of tpm_chip) to allocated_banks, > stores the number of allocated PCR banks in nr_allocated_banks (new member > of tpm_chip), and replaces the static array with a pointer to a dynamically > allocated array. > > tpm2_get_pcr_allocation() determines if a PCR bank is allocated by checking > the mask in the TPML_PCR_SELECTION structure returned by the TPM for > TPM2_Get_Capability(). One PCR bank with algorithm set to SHA1 is always > allocated for TPM 1.x. > > As a consequence of the introduction of nr_allocated_banks, > tpm_pcr_extend() does not check anymore if the algorithm stored in tpm_chip > is equal to zero. > > Fixes: 1db15344f874 ("tpm: implement TPM 2.0 capability to get active > PCR banks") > > Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx> There should not be a newline between tags and I don't think this should have fixes tag. Otherwise, looks good. Tested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> /Jarkko