Re: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 13, 2018 at 11:58:58AM +0000, Winkler, Tomas wrote:
> Yes, w/o this constrain it would be okay to request locality only once, 
> we can ask tboot ask again but at the time the requirement was that locality can be taken of at any point, 
> I believe that the locality won't be granted till a single command is completed.

But then tboot could race between requesting a locality and sending
the command (like immediately after the locality has been granted).

> Anyhow still the power gating is wrong in this patch do not ignore
> that part.

I can certainly take steps back with gating. It is not a blocker for
other changes but I do need to explain it in the changelog what problem
does cause. I'm not ignoring it. I just don't understad what is wrong.

> Thanks
> Tomas

/Jarkko



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux