On Sun, 2018-11-11 at 10:57 -0800, James Bottomley wrote: > On Sun, 2018-11-11 at 19:50 +0100, Michael Niewöhner wrote: > [...] > > > However, this makes me wonder about yours: > > > > > > > [ 0.003517] ACPI: TPM2 0x000000009E490ED8 000034 (v03 LENOVO > > > > TC- > > > > S06 00001300 AMI 00000000) > > > > > > I thought the Lenovo "upgrade to 2.0" in fact disabled the external > > > TPM in favour of the Intel PTT (software TPM in the management > > > engine). Since you apparently have the tpm_crb driver that should > > > find the PTT TPM, this might be one of the attachment bugs in the > > > CRB driver ... from your ACPI output it looks to be not specifying > > > the Tpm2Tabl. > > > > Well, there are at least two implementations I know of: > > For my Lenovo X260 I can choose between Infineon TPM 1.2 or Intel PTT > > TPM 2.0 This here is my ThinkStation P320 which can choose between > > PTT 1.2, PTT 2.0, > > Nuvoton 1.2 and 2.0. When switchting between 1.2 and 2.0 the Nuvoton > > gets > > reflashed with the appropriate firmware. > > Well, I still think the ACPI setup is incorrect. What's in > /sys/class/platform (should be directories of ACPI devices)? The TPM > is supposed to show up as MSFT0101. If it doesn't is there any other > device string in there that might be a TPM? Nope. I'm not sure if it should show up in ACPI... isn't TPM 2.0 I2C? $ find /sys | grep -i tpm /sys/class/tpmrm /sys/class/tpm /sys/bus/platform/drivers/tpm_tis /sys/bus/platform/drivers/tpm_tis/uevent /sys/bus/platform/drivers/tpm_tis/bind /sys/bus/platform/drivers/tpm_tis/unbind /sys/bus/pnp/drivers/tpm_tis /sys/bus/pnp/drivers/tpm_tis/uevent /sys/bus/pnp/drivers/tpm_tis/bind /sys/bus/pnp/drivers/tpm_tis/unbind /sys/bus/acpi/drivers/tpm_crb /sys/bus/acpi/drivers/tpm_crb/uevent /sys/bus/acpi/drivers/tpm_crb/bind /sys/bus/acpi/drivers/tpm_crb/unbind /sys/bus/i2c/drivers/tpm_i2c_nuvoton /sys/bus/i2c/drivers/tpm_i2c_nuvoton/uevent /sys/bus/i2c/drivers/tpm_i2c_nuvoton/bind /sys/bus/i2c/drivers/tpm_i2c_nuvoton/unbind > > James >