On Thu, Nov 08, 2018 at 03:47:39PM +0100, Roberto Sassu wrote: > > > + for (i = 0; i < chip->nr_active_banks && > > > + chip->active_banks[i].alg_id != digest_struct->alg_id; i++) > > > + ; > > > > Not sure if the semicolon should be in its own line. > > scripts/Lindent suggests: > > for (i = 0; i < chip->nr_active_banks && > chip->active_banks[i].alg_id != digest_struct->alg_id; > i++) ; > > but this is not accepted by scripts/checkpatch.pl (there are no > warnings/errors on the patch I sent). Yeah, not a really blocker for me. Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> /Jarkko