Re: [PATCH] security/integrity: remove unnecessary 'init_keyring' variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 21, 2018 at 03:02:14PM -0400, Mimi Zohar wrote:
> On Fri, 2018-09-21 at 11:54 -0700, Eric Biggers wrote:
> > On Fri, Sep 21, 2018 at 02:42:38PM -0400, Mimi Zohar wrote:
> > > On Fri, 2018-09-07 at 13:25 -0700, Eric Biggers wrote:
> > > > From: Eric Biggers <ebiggers@xxxxxxxxxx>
> > > > 
> > > > The 'init_keyring' variable actually just gave the value of
> > > > CONFIG_INTEGRITY_TRUSTED_KEYRING.  We should check the config option
> > > > directly instead.  No change in behavior; this just simplifies the code.
> > > 
> > > We try to minimize as much as possible "ifdefs" in C code.  This
> > > change is moving in the wrong direction.
> > 
> > So your preferred approach is to store the values of Kconfig options in
> > variables?  That defeats much of the point of having Kconfig options...
> 
> No, I prefer using "ifdefs" in include files, not C code, and defining
> stub functions.
> 
> Mimi
> 

integrity_init_keyring() is already stubbed out in a header.  What are you
suggesting, exactly?

- Eric



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux