On Tue, Sep 18, 2018 at 09:14:43AM +0200, Roberto Sassu wrote: > On 9/17/2018 11:16 PM, Jarkko Sakkinen wrote: > > On Mon, Sep 17, 2018 at 12:02:56PM +0200, Roberto Sassu wrote: > > > This code has the same behavior of tpm2_get_pcr_allocation(). If some > > > banks are not used, set the algorithm of the first unused to > > > TPM_ALG_ERROR. > > > > My point is that maybe it would sense to use zero for that in order > > to make code a bit simpler. > > Wouldn't be better to compare data with the same type? Since the alg_id > structure member stores an algorithm, it should be fine to compare its > value with an algorithm. > > No problem to change that, but probably I should modify also > tpm_pcr_extend(). > > Roberto Please do. /Jarkko
