On Mon, Sep 17, 2018 at 07:45:32AM -0700, James Bottomley wrote: > On Mon, 2018-09-17 at 10:32 -0300, Martin Galvan wrote: > > El dom., 16 sept. 2018 a las 16:16, Jarkko Sakkinen > > (<jarkko.sakkinen@xxxxxxxxxxxxxxx>) escribió: > > > I understand your concerns but without a concrete workload there is > > > no > > > problem with this behavior. > > > > IMHO it's a bit excessive to allocate 4k to end up storing than 100 > > bytes. Beyond that, it's a pretty big gotcha for someone who's > > writing software which talks to the driver :) > > It's what we do in the kernel, which is one of our most memory > constrained environments. > > You have to remember that sub page size buffers aren't always managed > the best at any level (they usually fragment the heap) so even in a > constrained memory environment, a 4k buffer (4k aligned) is usually > preferable. > > James If the commit is not too interfering I still could consider merging it as even if only for simplifying implementing a TPM user space. /Jarkko
