On 08/10/2018 10:27 AM, Jarkko Sakkinen wrote: > On Tue, Aug 07, 2018 at 01:27:44PM -0700, Tadeusz Struk wrote: >> Add a ptr to struct tpm_space to the file_priv to have an easy >> access to it in the async job without the need to allocate memory. >> This also allows to consolidate of the write operations for >> the two interfaces. > > I think the 2nd premise should be the priority and the first premise should > be removed as it is not needed in any possible way to justify the > change. Jarkko, The main reason why the pointer to tpm_space struct was added to the file_priv was to have access to space in the async job when it is enqueued via the /dev/tpm<N> interface. Currently it is only available in tpmrm_priv. Otherwise I would need to introduce yet another struct what would consist of a ptr file_priv and a ptr to tpm_space and allocate it on every enqueue. Much easier was to to it this way. The consolidation was only a side effect of this so I think the description is correct. Thanks, -- Tadeusz
