On Fri, Jun 29, 2018 at 08:47:43PM +0300, Jarkko Sakkinen wrote: > On Fri, Jun 29, 2018 at 09:31:41AM -0600, Jason Gunthorpe wrote: > > > -#if defined(CONFIG_TCG_TPM) || defined(CONFIG_TCG_TPM_MODULE) > > > - > > > +#if defined(CONFIG_TCG_TPM) > > > > Huh. This new version is certainly right > > Hmm... > > If the option is kept as tristate, shouldn't this be actually: > > #if defined(CONFIG_TCG_TPM) && !defined(CONFIG_TCG_TPM_MODULE) > > ? Er, yes, it should be writte as #if IS_ENABLED(CONFIG_TCG_TPM) these days Jason
