Re: [PATCH v2 01/10] tpm/tpm_i2c_infineon: switch to i2c_lock_bus(..., I2C_LOCK_SEGMENT)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 01/10] tpm/tpm_i2c_infineon: switch to i2c_lock_bus(..., I2C_LOCK_SEGMENT)
From: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
Date: Mon, 25 Jun 2018 13:24:54 +0300
Cc: linux-kernel@xxxxxxxxxxxxxxx, Peter Huewe <peterhuewe@xxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Brian Norris <computersforpeace@xxxxxxxxx>, Gregory Fong <gregory.0xf0@xxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, bcm-kernel-feedback-list@xxxxxxxxxxxx, Sekhar Nori <nsekhar@xxxxxx>, Kevin Hilman <khilman@xxxxxxxxxx>, Haavard Skinnemoen <hskinnemoen@xxxxxxxxx>, Kukjin Kim <kgene@xxxxxxxxxx>, Krzysztof Kozlowski <krzk@xxxxxxxxxx>, Orson Zhai <orsonzhai@xxxxxxxxx>, Baolin Wang <baolin.wang@xxxxxxxxxx>, Chunyan Zhang <zhang.lyra@xxxxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Crt Mori <cmo@xxxxxxxxxxx>, Jonathan Cameron <jic23@xxxxxxxxxx>, Hartmut Knaack <knaack.h@xxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, Antti Palosaari <crope@xxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Michael Krufky <mkrufky@xxxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, linux-integrity@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx
In-reply-to: <20180620051803.12206-2-peda@axentia.se>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-agent: Mutt/1.9.4 (2018-02-28)

On Wed, Jun 20, 2018 at 07:17:54AM +0200, Peter Rosin wrote:
> Locking the root adapter for __i2c_transfer will deadlock if the
> device sits behind a mux-locked I2C mux. Switch to the finer-grained
> i2c_lock_bus with the I2C_LOCK_SEGMENT flag. If the device does not
> sit behind a mux-locked mux, the two locking variants are equivalent.
> 
> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>

Studied enough so that I can give

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

Do not have hardware to test this, however.

/Jarkko

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH v2 01/10] tpm/tpm_i2c_infineon: switch to i2c_lock_bus(..., I2C_LOCK_SEGMENT)
  - From: Alexander Steffen

References:
- [PATCH v2 00/10] Split i2c_lock_adapter into i2c_lock_root and i2c_lock_segment
  - From: Peter Rosin
- [PATCH v2 01/10] tpm/tpm_i2c_infineon: switch to i2c_lock_bus(..., I2C_LOCK_SEGMENT)
  - From: Peter Rosin

Prev by Date: Re: IMA: Deadlock in ima_appraise_measurement when /bin/kmod carries a digsig in security.evm
Next by Date: [PATCH v4 4/5] ima: Use tpm_default_chip() and call TPM functions with a tpm_chip
Previous by thread: [PATCH v2 01/10] tpm/tpm_i2c_infineon: switch to i2c_lock_bus(..., I2C_LOCK_SEGMENT)
Next by thread: Re: [PATCH v2 01/10] tpm/tpm_i2c_infineon: switch to i2c_lock_bus(..., I2C_LOCK_SEGMENT)
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Linux Kernel Hardening] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux SCSI]