On Wed, Jun 06, 2018 at 11:01:42AM +0000, Winkler, Tomas wrote: > > > > On Wed, May 30, 2018 at 10:52:28AM +0000, Winkler, Tomas wrote: > > > > > > > > On Wed, May 23, 2018 at 01:48:17PM +0000, Winkler, Tomas wrote: > > > > > > > > > > > On Tue, May 22, 2018 at 09:27:46AM +0000, Winkler, Tomas wrote: > > > > > > > > > > > > > > > > On Wed, May 16, 2018 at 10:46:00PM +0300, Tomas Winkler > > wrote: > > > > > > > > > New wrappers are added tpm_cmd_ready() and tpm_go_idle() > > > > > > wrappers > > > > > > > > > to streamline tpm_try_transmit code. > > TPM_TRANSMIT_UNLOCKED > > > > > > > > > flag > > > > > > is > > > > > > > > abused > > > > > > > > > to resolve tpm spaces recursive calls to tpm_transmit(). > > > > > > > > > > > > > > > > This looks good and all but I don't think we want to abuse > > > > > > > > anything in the driver code, do we? > > > > > > > > > > > > > > It's not abuse just the flag UNLOCKED is not really named > > > > > > > correctly I think this has to be backported so wanted to do > > > > > > > less invasive > > > > change. > > > > > > > > > > > > It should be renamed anyway and possible merge conflicts are not > > > > > > hard to sort out in this change. Can you rename it as SPACE? > > > > > > > > > > Not sure, I believe UNLOCKED is still better name than SPACE, I'm > > > > >not sure this is Do you also want to remove TPM_TRANSMIT_RAW? > > > > > clk_enable is handling its own anti recursion counter 'data- > > > > >clkrun_enabled' > > > > > but it should be all handled under one flag I guess. > > > > > > > > > > > Right, and even without rename this will probably cause merge > > > > > > conflicts at least in v4.4 an v4.9 since in-kernel RM landed in > > > > > > v4.12, so not much gain not do the rename :-) > > > > > > > > > > I belive we should do minimal change and the big cleanup after that. > > > > > Not sure, I believe UNLOCKED is still better name than SPACE even > > > > > it wasn't > > > > the original intention. > > > > > No the SPACE is the issue, but any recursion call into > > > > > tpm_transmit. A bigger change is needed and rename to SPACE would > > > > > be just another > > > > intermediat change. > > > > > > > > > > Please reconsider. > > > > > > > > > > Thanks > > > > > Tomas > > > > > > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > > > > > > > > > Does it mean you're Okay with the patch now? > > > Thanks > > > Tomas > > > > The change looks good but I'll have to test it. > Any updates? > Thanks Tested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> /Jarkko
