On Tue, 2018-03-06 at 11:30 +0200, Tomas Winkler wrote: > Factor out get random implementation from tpm-interface.c > into tpm1_get_random function in tpm1-cmd.c. > No functional changes. > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> While you are doing this, please make it use tpm_buf so tha we get stuff out of that nasty union. Using "helper" structs is still fine, just move it right before the function implementation out of tpm.h (there are examples of this tpm2-cmd.c). /Jarkko