On Tue, Jan 23, 2018 at 08:33:22AM -0700, Jason Gunthorpe wrote: > On Tue, Jan 23, 2018 at 03:08:41PM +0200, Jarkko Sakkinen wrote: > > On Tue, Jan 23, 2018 at 01:27:30PM +0200, Tomas Winkler wrote: > > > We cannot use go_idle cmd_ready commands via runtime_pm handles > > > as with the introduction of localities this is no longer an optional > > > feature, while runtime pm can be not enabled. > > > Though cmd_ready/go_idle provides power saving feature, it's also part of > > > TPM2 protocol and should be called explicitly. > > > This patch exposes cmd_read/go_idle via tpm class ops and removes > > > runtime pm support as it is not used by any driver. > > > > > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> > > > > Thank you. > > > > LGTM > > > > Jason, what do you think? > > The PM stuff has been the source of confusion for a while, seems > reasonable to get rid of it. I'll test this ASAP. /Jarkk