On Thu, Jan 18, 2018 at 08:45:10PM +0200, Jarkko Sakkinen wrote: > For SGX code that I've been upstreaming to arch/x86 tree the feedback > was that local variable declarations should be in line length order, > which makes sense to me i.e. startup_succesful should be the first > declaration. AFAIK that 'reverse christmas tree' style particularly local to the net tree, not a general kernel style guideline. We've never used it in TPM for instance. Jason