On Fri, Dec 08, 2017 at 07:46:51PM +0100, Alexander Steffen wrote: > There are several TIS registers that contain information on how exactly the > TPM implements the TIS protocol. Complex commands that are used by the > probe functions should only be sent to the TPM after all other registers > have been read and the driver is properly configured to handle those > transactions. > > Signed-off-by: Alexander Steffen <Alexander.Steffen@xxxxxxxxxxxx> The code change looks ok but the commit message does not describe what the commit does. It describes a guideline and uses an abstract term "complex command". /Jarkko