On Wed, Jan 17, 2018 at 02:38:59PM +0000, André Draszik wrote: > > > [...] > > > > Please be very clear about exactly what security properties are achieved > > by > > using encrypted-keys. > > I've left out all of this in the updated documentation, as any such > information should probably be in Documentation/security/keys/trusted- > encrypted.rst in the first place. Where is this document going to be found / when will it be written? It seems really odd to be requesting a do code review when the specifications aren't available and/or haven't been written yet. I prefer to review the *design* first, as opposed to trying to both review the code and try to guess at the design and review my guess of the design at the same time.... - Ted