On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote: > - return tpm_chip_register(chip); > + rc = tpm_chip_register(chip); > + if (rc && is_bsw()) > + iounmap(priv->ilb_base_addr); > + > + return rc; > out_err: > tpm_tis_remove(chip); > + if (is_bsw()) > + iounmap(priv->ilb_base_addr); > + > return rc; > } I thought you were resending this to fix the above, why is is it still wonky? Jason