On 12/21/2017 04:39 PM, Shaikh, Azhar wrote: > HI Javier, > > >> -----Original Message----- >> From: linux-integrity-owner@xxxxxxxxxxxxxxx [mailto:linux-integrity- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Javier Martinez Canillas >> Sent: Thursday, December 21, 2017 4:49 AM >> To: Shaikh, Azhar <azhar.shaikh@xxxxxxxxx>; Jason Gunthorpe >> <jgg@xxxxxxxx> >> Cc: linux-kernel@xxxxxxxxxxxxxxx; James Ettle <james@xxxxxxxxxxxx>; Hans de >> Goede <hdegoede@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Jarkko >> Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>; Peter Huewe >> <peterhuewe@xxxxxx>; Greg Kroah-Hartman >> <gregkh@xxxxxxxxxxxxxxxxxxx>; linux-integrity@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already unmapped I/O >> memory region >> >> Hello Azhar, >> >> On 12/20/2017 08:15 PM, Shaikh, Azhar wrote: >>> >>> >>>> -----Original Message----- >>>> From: Jason Gunthorpe [mailto:jgg@xxxxxxxx] >>>> Sent: Wednesday, December 20, 2017 10:55 AM >>>> To: Javier Martinez Canillas <javierm@xxxxxxxxxx> >>>> Cc: linux-kernel@xxxxxxxxxxxxxxx; James Ettle <james@xxxxxxxxxxxx>; >>>> Hans de Goede <hdegoede@xxxxxxxxxx>; Shaikh, Azhar >>>> <azhar.shaikh@xxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Jarkko >>>> Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>; Peter Huewe >>>> <peterhuewe@xxxxxx>; Greg Kroah-Hartman >> <gregkh@xxxxxxxxxxxxxxxxxxx>; >>>> linux- integrity@xxxxxxxxxxxxxxx >>>> Subject: Re: [PATCH 1/4] tpm: fix access attempt to an already >>>> unmapped I/O memory region >>>> >>>> On Wed, Dec 20, 2017 at 07:21:31PM +0100, Javier Martinez Canillas wrote: >>>> >>>>>> The below draft fixes everything except #1. That needs a more >>>>>> thoughtful idea.. >>>>>> >>>>> >>>>> I'll just drop this patch from the series and you can fix all the >>>>> issues in the error / driver removal paths. It's not a dependency >>>>> anyways, I included it just because noticed the issue while reading the >> code. >>>> >>>> Azhar, this means it becomes your problem :) >>>> >>> >>> Sure, I will fix this. >>> Javier you can drop this patch. >>> >> >> On a second though, we should just merge $SUBJECT since is an obvious fix >> for one of the issues. Then you could fix the remaining bugs in error and >> driver removal paths. > > I think you are asking to keep this patch as a part of this series, itself and not upload separately. Is this correct? Please correct me if I am wrong. > Yes, what I meant is that we should just keep this patch in the series since it fixes one of the resource cleanup bugs. Then you can fix the other issues as a follow-up. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat
