On Wed, Dec 20, 2017 at 03:19:19PM +0000, Shaikh, Azhar wrote: > >This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell > >systems, but the only way this can happen is if the code is not correct. > > > >So it's an unnecessary check that just makes the code harder to read. > > This code was implemented as a suggestion from Jason on the previous patches. > https://www.spinics.net/lists/linux-integrity/msg00827.html The concept was to be like ASSERT_RTNL, maybe it just needs a suitably named static inline to addrress Javier's readability concerns? Jason
