On 12/16/2017 06:01 PM, Jarkko Sakkinen wrote: > On Fri, 2017-12-15 at 10:38 -0700, Jason Gunthorpe wrote: >> On Fri, Dec 15, 2017 at 04:56:30PM +0200, Jarkko Sakkinen wrote: >>> On Thu, Dec 14, 2017 at 12:10:52PM -0700, Jason Gunthorpe wrote: >>>> On Thu, Dec 14, 2017 at 08:08:58PM +0100, Javier Martinez Canillas wrote: >>>> >>>>> Although probably reverting the offending commits is the right thing to do >>>>> until a proper solution is proposed. >>>> >>>> Yes, if a fix is not forthcoming soon Jarkko should revert. >>>> >>> >>> I think I should drop the current patch going to 4.16 and revert the old >>> patch. Do we agree on this? >> >> I think the entire is_bsw thing needs to go, clearly manipulating >> CLKRUN directly was not fully thought out? >> >> Hopefully Intel will come up with a fix patch to preserve PS/2 >> functionality and it won't come to a revert.. > > Agreed. > Agreed. Although it would be good to have a solution soon, because this has been broken since v4.13 and v4.15-rc4 is likely to come this weekend. So we may end with Braswell system being non-function for 3 kernel releases... As mentioned I can write a patch to hide this behavior under a Kconfig option that's disabled by default (and maybe depend on BROKEN) or a module parameter until a proper solution is found. > /Jarkko > Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat
