On Thu, Dec 14, 2017 at 04:23:29PM +0000, Alexander.Steffen@xxxxxxxxxxxx wrote: > Hi Jarkko, > > during the Kernel Summit in Prague I talked with Shuah Khan about > kselftest and the possibility to integrate TPM tests into that > framework. What would you think about your tests > (https://github.com/jsakkine-intel/tpm2-scripts) living there? > > This way, those tests would get more visibility/popularity with other > developers, and thus hopefully more contributors that can use that > framework as a starting point. It also allows us to have a common test > set, that all TPM developers can easily use for their work. And the > tests being integrated into the kernel repository would avoid issues > like I had just now, where your new test for invalid command codes > failed when I tried to run it on an older kernel that did not have > that functionality implemented. > > Currently, most tests within kselftest are not implemented in Python, > but Shuah did not sound strictly opposed to that idea. In fact, some > Python-based tests already have made it into the tree > (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/tc-testing), > though they do not seem to be called by kselftest by default. > > Alexander I'm fine with this. /Jarkko
