On Tue, Nov 21, 2017 at 11:58:56AM -0700, Jason Gunthorpe wrote: > On Tue, Nov 21, 2017 at 10:28:58AM -0800, Guenter Roeck wrote: > > > I'll split the patch into two parts, and only add (hopefully) > > non-controversial tpm2 attributes for now (which I think is durations > > and timeouts). Or, in other words, I'll split the attributes into > > two groups - one generic and one for tpm1. > > Ok. Please look at new attributes you wish to add for tpm2 and see if > they meet the modern sysfs sensibility of one value per file, etc. > > Jason In general: if something can be retrieved through /dev/tpm0, there is no any sane reason to have a sysfs attribute for such. /Jarkko