>-----Original Message-----
>From: Sakkinen, Jarkko
>Sent: Wednesday, November 15, 2017 12:14 AM
>To: Jason Gunthorpe <jgg@xxxxxxxx>
>Cc: Shaikh, Azhar <azhar.shaikh@xxxxxxxxx>; linux-integrity@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH RFC v2 2/2] tpm_tis: Move ilb_base_addr to
>tpm_tis_tcg_phy
>
>On Tue, Nov 14, 2017 at 04:28:12PM -0700, Jason Gunthorpe wrote:
>> On Tue, Nov 07, 2017 at 01:32:08PM -0800, Azhar Shaikh wrote:
>>
>> > +#ifdef CONFIG_X86
>> > + if (is_bsw())
>> > + iounmap(phy->ilb_base_addr);
>> > +#endif
>>
>> This whole thing would be much better if is_bsw was just
>>
>> bool is_bsw(void)
>> {
>> if (!IS_ENABLED(CONFIG_X86))
>> return false;
>> [..]
>> }
>>
>> Then drop every single one of these #ifdef CONFIG_X86
>>
>> Jason
>
>+1
>
Thank you for the suggestion.
Will incorporate this in next patch series.
>/Jarkko
