On Mon, Nov 06, 2017 at 10:11:39PM +0000, Shaikh, Azhar wrote: > >Why are you using a mixture of callbacks and linked functions to > >solve this problem? > > > >Can't you do everything with callbacks? > > > > I have set the flag TPM_TIS_CLK_ENABLE in the callback. But then in > tpm_platform_begin_xfer() I want it to run once to disable clkrun > and then return for all other instances, till the the flag is > cleared. If I just set the flag in tpm_tis_clkrun_toggle(), then > for any TPM transaction after that the clkrun will not be disabled > with current implementation. Hence calling it once before setting > the flag so that it is kept enabled for the next transaction. I mean, why do we have global functions called tpm_platform_begin_xfer at all, everything should be in a callback, not some mixture. The static function sort of made sense when it was only ever called by the tis driver, but now that you are hoisting things up a layer it is not okay anymore, you need to add new driver callbacks instead. > +++ b/drivers/char/tpm/tpm_tis.c > @@ -140,6 +140,7 @@ static int check_acpi_tpm2(struct device *dev) > #define LPC_CLKRUN_EN (1 << 2) > > static void __iomem *ilb_base_addr; > +static bool run_once; No global statics. The ilb_base_addr global is really ugly you should move it to struct tpm_tis_tcg_phy Jason
