Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote: >> >> >> On Tue, 17 Oct 2017, Dan Carpenter wrote: >> >> > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote: >> > > >> > > A minor complaint: all commits are missing "Fixes:" tag. >> > > >> > >> > Fixes is only for bug fixes. These don't fix any bugs. >> >> 0-day seems to put Fixes for everything. Should they be removed when the >> old code is undesirable but doesn't actually cause a crash, eg out of date >> API. > > Yeah, I feel like Fixes tags don't belong for API updates and cleanups. I try to use the criteria of "if someone had backported commit A, would they also want commit B" (where B Fixes: A). So it's a bit broader than just "A had a *bug*" and this is the fix. That's obviously still a bit of a slippery slope, but somewhat helpful I think. eg, pretty much no one is interested in backporting spelling fixes, so those aren't Fixes. And generally people aren't interested in backporting commits like these ones that just update coding style. cheers
