Once device_add() failed, we should call put_device() to decrement reference count for cleanup. Or it could cause memory leak. As comment of device_add() says, 'if device_add() succeeds, you should call device_del() when you want to get rid of it. If device_add() has not succeeded, use only put_device() to drop the reference count'. Found by code review. Cc: stable@xxxxxxxxxxxxxxx Fixes: 0cd587735205 ("Input: preallocate memory to hold event values") Signed-off-by: Ma Ke <make24@xxxxxxxxxxx> --- drivers/input/input.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/input.c b/drivers/input/input.c index c9e3ac64bcd0..2e70f346dadc 100644 --- a/drivers/input/input.c +++ b/drivers/input/input.c @@ -2424,6 +2424,7 @@ int input_register_device(struct input_dev *dev) err_device_del: device_del(&dev->dev); err_devres_free: + put_device(&dev->dev); devres_free(devres); return error; } -- 2.25.1