On Sat, 8 Mar 2025, at 3:55 PM, kernel test robot wrote: > Hi Luke, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on hid/for-next] > [also build test ERROR on linus/master v6.14-rc5 next-20250307] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/Luke-Jones/hid-asus-check-ROG-Ally-MCU-version-and-warn/20250227-165941 > base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git > for-next > patch link: > https://lore.kernel.org/r/20250227085817.1007697-3-luke%40ljones.dev > patch subject: [PATCH v3 2/2] platform/x86: asus-wmi: Refactor Ally > suspend/resume > config: mips-allyesconfig > (https://download.01.org/0day-ci/archive/20250308/202503081003.gNlKWt4M-lkp@xxxxxxxxx/config) > compiler: mips-linux-gcc (GCC) 14.2.0 > reproduce (this is a W=1 build): > (https://download.01.org/0day-ci/archive/20250308/202503081003.gNlKWt4M-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new > version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: > https://lore.kernel.org/oe-kbuild-all/202503081003.gNlKWt4M-lkp@xxxxxxxxx/ > > All errors (new ones prefixed by >>): > > In file included from drivers/hid/hid-asus.c:29: > include/linux/platform_data/x86/asus-wmi.h: In function 'set_ally_mcu_hack': >>> include/linux/platform_data/x86/asus-wmi.h:168:16: error: 'return' with a value, in function returning void [-Wreturn-mismatch] > 168 | return -ENODEV; > | ^ > include/linux/platform_data/x86/asus-wmi.h:166:20: note: declared > here > 166 | static inline void set_ally_mcu_hack(bool enabled) > | ^~~~~~~~~~~~~~~~~ > include/linux/platform_data/x86/asus-wmi.h: In function > 'set_ally_mcu_powersave': > include/linux/platform_data/x86/asus-wmi.h:172:16: error: 'return' > with a value, in function returning void [-Wreturn-mismatch] > 172 | return -ENODEV; > | ^ > include/linux/platform_data/x86/asus-wmi.h:170:20: note: declared > here > 170 | static inline void set_ally_mcu_powersave(bool enabled) > | ^~~~~~~~~~~~~~~~~~~~~~ *Groaning sounds*. Ilpo/Hans, you guys want me to fix this and submit new series or can this be corrected when pulled in? There's two more of the same below this. > > vim +/return +168 include/linux/platform_data/x86/asus-wmi.h > > 159 > 160 #if IS_REACHABLE(CONFIG_ASUS_WMI) > 161 void set_ally_mcu_hack(bool enabled); > 162 void set_ally_mcu_powersave(bool enabled); > 163 int asus_wmi_set_devstate(u32 dev_id, u32 ctrl_param, u32 > *retval); > 164 int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1, > u32 *retval); > 165 #else > 166 static inline void set_ally_mcu_hack(bool enabled) > 167 { > > 168 return -ENODEV; > 169 } > 170 static inline void set_ally_mcu_powersave(bool enabled) > 171 { > 172 return -ENODEV; > 173 } > 174 static inline int asus_wmi_set_devstate(u32 dev_id, u32 > ctrl_param, u32 *retval) > 175 { > 176 return -ENODEV; > 177 } > 178 static inline int asus_wmi_evaluate_method(u32 method_id, u32 > arg0, u32 arg1, > 179 u32 *retval) > 180 { > 181 return -ENODEV; > 182 } > 183 #endif > 184 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki
