On Wed, 2025-03-12 at 09:08 +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@xxxxxxxx>
>
> The line
>
> obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER) += intel-ish-hid/
>
> in top-level HID Makefile is both superfluous (as
> CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER
> depends on CONFIG_INTEL_ISH_HID, which contains intel-ish-hid/
> already) and wrong (as it's
> missing the CONFIG_ prefix).
>
> Just remove it.
>
> Reported-by: Jiri Slaby <jirislaby@xxxxxxxxxx>
> Fixes: 91b228107da3e ("HID: intel-ish-hid: ISH firmware loader client
> driver")
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxxx>
Good one
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
Thanks,
Srinivas
> ---
> drivers/hid/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
> index 482b096eea28..0abfe51704a0 100644
> --- a/drivers/hid/Makefile
> +++ b/drivers/hid/Makefile
> @@ -166,7 +166,6 @@ obj-$(CONFIG_USB_KBD) += usbhid/
> obj-$(CONFIG_I2C_HID_CORE) += i2c-hid/
>
> obj-$(CONFIG_INTEL_ISH_HID) += intel-ish-hid/
> -obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER) += intel-ish-hid/
>
> obj-$(CONFIG_AMD_SFH_HID) += amd-sfh-hid/
>
