> On 7 Mar 2025, at 12:24 AM, Aditya Garg <gargaditya08@xxxxxxxx> wrote: > > > >> On 6 Mar 2025, at 12:30 PM, Grigorii Sokolik <g.sokol99@xxxxxxxxxxxx> wrote: >> >> Add Apple Magic Keyboard 2024 model (with USB-C port) device ID (0321) >> to those recognized by the hid-apple driver. Keyboard is otherwise >> compatible with the existing implementation for its earlier 2021 model. >> >> Signed-off-by: Grigorii Sokolik <g.sokol99@xxxxxxxxxxxx> >> --- >> drivers/hid/hid-apple.c | 5 +++++ >> drivers/hid/hid-ids.h | 1 + >> 2 files changed, 6 insertions(+) >> >> --- a/drivers/hid/hid-ids.h >> +++ b/drivers/hid/hid-ids.h >> @@ -185,6 +185,7 @@ >> #define USB_DEVICE_ID_APPLE_IRCONTROL5 0x8243 >> #define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2021 0x029c >> #define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024 0x0320 >> +#define USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024_V2 0x0320 A3118 is the one with Touch ID. Name should be USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_FINGERPRINT_2024 to be more clear. > > It’s the same ID as USB_DEVICE_ID_APPLE_MAGIC_KEYBOARD_2024, why are you adding this again? Typo? > > Also, please use switch case, you can submit your patch as a part of: > > https://lore.kernel.org/linux-input/A50C1CF0-B927-4FCF-828F-1F5F79BA3762@xxxxxxxx/ > > Just resubmit those 2 patches along with your patch and make a v2.
