> -----Original Message----- > From: Jiri Kosina <jikos@xxxxxxxxxx> > Sent: Wednesday, March 5, 2025 1:36 PM > To: Xu, Even <even.xu@xxxxxxxxx> > Cc: bentiss@xxxxxxxxxx; srinivas.pandruvada@xxxxxxxxxxxxxxx; mpearson- > lenovo@xxxxxxxxx; linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: RE: [PATCH RESEND v1] HID: Intel-thc-hid: Intel-quickspi: Correct device > state after S4 > > On Wed, 5 Mar 2025, Xu, Even wrote: > > > > I'll now apply this as-is because the code is already in, but > > > perhaps renaming the flag to QUICKI2C_RESET would be in order. > > > > Current patch is still needed, quickspi device init flow is: init -> > > resetting -> reset -> enabled. Exiting code in pm restore() callback > > takes reset operation and puts device into reset state, but forgets > > move to enabled state after init flow is done. > > > > Thanks for your suggestion! Let me refine the patch in V2. > > I have already applied your v1 patch to upstream-fixes queue so that it could go to > Linus quickly, as an important functional fix. > > So please base the naming fixup on top of that. Thanks Jiri! I didn't realize v1 patch already got applied, just sent out v2 patch this morning. If so, could you just pick " [PATCH v2 1/2] HID: Intel-thc-hid: Intel-quickspi: Correct device state names gramatically" from v2 patch set for the naming fix? Those two patches have no confliction/dependence. Thank you very much! Best Regards, Even Xu > > Thanks, > > -- > Jiri Kosina > SUSE Labs
