On Mon, Feb 17, 2025 at 05:27:42AM +0000, Aditya Garg wrote:
> >> 397
> >> 398 ret = hid_hw_open(hdev);
> >> 399 if (ret) {
> >> 400 dev_err_probe(dev, ret, "HID hw open failed\n");
> >> 401 goto stop_hw;
> >> 402 }
> >> 403
> >> 404 kbd->backlight_dev = backlight_device_get_by_name("appletb_backlight");
> >> 405 if (!kbd->backlight_dev)
> >> --> 406 dev_err_probe(dev, ret, "Failed to get backlight device\n");
> >> ^^^
> >> s/ret/-EINVAL/?
> >
> > Should be -ENODEV
> >
> >>
> >> Why is this indented an extra tab?
> >
> > Thanks for pointing this out.
> >
> > Patch series with some issues I myself found out, along with the one you flagged are sent here:
>
>
> Btw, I wonder what’s wrong with checkpatch. I didn't get any errors/warnings regarding these.
These are Smatch warnings:
https://github.com/error27/smatch/blob/master/Documentation/smatch.rst
~/smatch_dir/smatch_scripts/kchecker drivers/hid/hid-appletb-kbd.c
regards,
dan carpenter
