Re: [PATCH] hid: Kconfig: Add LEDS_CLASS_MULTICOLOR dependency to HID_LOGITECH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 11 Feb 2025, Kate Hsuan wrote:

> The test bot found an issue with building hid-lg-g15.
> 
> All errors (new ones prefixed by >>):
> 
>    powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g510_kbd_led_write':
> >> drivers/hid/hid-lg-g15.c:241:(.text+0x768): undefined reference to `led_mc_calc_color_components'
>    powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g15_register_led':
> >> drivers/hid/hid-lg-g15.c:686:(.text+0xa9c): undefined reference to `devm_led_classdev_multicolor_register_ext'
> 
> Since multicolor LED APIs manage the keyboard backlight settings of
> hid-lg-g15, the LEDS_CLASS_MULTICOLOR dependency was added to
> HID_LOGITECH.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502110032.VZ0J024X-lkp@xxxxxxxxx/
> Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx>

I've added

	Fixes: a3a064146c50 ("HID: hid-lg-g15: Use standard multicolor LED API")

make the 'HID:' prefix in shortlog uppercase, and applied.

Thanks,

-- 
Jiri Kosina
SUSE Labs





[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux