On Mon, Feb 3, 2025 at 2:57 PM Jiri Kosina <jikos@xxxxxxxxxx> wrote: > > On Thu, 16 Jan 2025, Alex Henrie wrote: > > diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c > > index 7e1ae2a2bcc2..9767d17941d0 100644 > > --- a/drivers/hid/hid-apple.c > > +++ b/drivers/hid/hid-apple.c > > @@ -545,6 +545,9 @@ static int hidinput_apple_event(struct hid_device *hid, struct input_dev *input, > > } > > } > > > > + if (usage->hid == 0xc0301) /* Omoton KB066 quirk */ > > + code = KEY_F6; > > + > > Sorry, it's not clear to me from the changelog why it's not possible to > make this quirk apply only in case we're known to have 0x5ac/0x022c > device. Is this VID/PID shared with other, differently-behaving devices? The real Apple A1255 and the Omoton KB066 are both 05ac:022c. The hid-apple driver is only used for devices that have VID 05ac, so there's no need to check the VID again. We could restrict the quirk to PID 022c only, but if the keyboard emits the reserved code 0xC0301, it's surely an Omoton KB066 because no other keyboard uses that code. What would be the advantage to adding a PID check? -Alex
