Hi Jens, On Mon, Feb 03, 2025 at 06:43:09PM +0100, Jens Reidel wrote: > > - error = regmap_raw_read(cd->regmap, GOODIX_BERLIN_FW_VERSION_INFO_ADDR, > + if (ic_data->ic_type == IC_TYPE_BERLIN_A) > + fw_version_info_addr = GOODIX_BERLIN_FW_VERSION_INFO_ADDR_A; > + else > + fw_version_info_addr = GOODIX_BERLIN_FW_VERSION_INFO_ADDR; > + Instead of branching on IC type please have goodix_berlin_ic_data structure describe differences in the chips (by adding fw_version_info_addr, ic_info_addr and other fields) and then simply use them. Thanks. -- Dmitry
