On Thu, Jan 23, 2025 at 07:04:58AM +0100, Greg KH wrote: > On Wed, Jan 22, 2025 at 06:47:07PM -0300, Nilton Perim Neto wrote: > > Added to the xpad driver the following controllers: > > 8BitDo SN30 Pro, Hyperkin X91 and Gamesir G7 SE > > Also changed the VIDs to better describe them > > When you say "also" that's a huge hint that this should be broken up > into multiple patches, right? Renaming an id has nothing to do with > adding a new one. It was a bad wording. Vendor macros were not changed, only comments were updated to reflect the fact that some of the macros cover more than a single controller. It does not make sense to split this apart. Thanks. -- Dmitry
