On Wed, 22 Jan 2025, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> A previous patch tried to fix this link failure:
>
> x86_64-linux-ld: drivers/hid/hid-lenovo.o: in function `lenovo_raw_event':
> hid-lenovo.c:(.text+0x22c): undefined reference to `platform_profile_cycle'
>
> but got it wrong in three ways:
>
> - the link failure still exists with CONFIG_ACPI_PLATFORM_PROFILE=m
> when hid-lenovo is built-in
>
> - There is no way to manually enable CONFIG_ACPI_PLATFORM_PROFILE, as
> it is intended to be selected by its users.
>
> Remove the broken #if check again and instead select the symbol like
> the other users do. This requires adding a dependency on CONFIG_ACPI.
>
> Fixes: 52e7d1f7c2fd ("HID: lenovo: Fix undefined platform_profile_cycle in ThinkPad X12 keyboard patch")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Thanks a lot for the fix Arnd, applied to hid.git#for-6.14/upstream-fixes.
--
Jiri Kosina
SUSE Labs
