On Tue, 21 Jan 2025 at 11:10, Oliver Neukum <oneukum@xxxxxxxx> wrote: > > On 19.01.25 14:13, Tomasz Pakuła wrote: > > Some PID compliant devices automatically play effects after boot (i.e. > > autocenter spring) that prevent the rendering of other effects since > > it is done outside the kernel driver. > > > > This makes sure all the effects currently played are stopped after > > resetting the device. > > It brings compatibility to the Brunner CLS-P joystick and others > > Hi, > > it seems to me that the same thing would happen upon resumption > from S4. Will this be handled? > > Regards > Oliver > Turns out, the whole pidff_reset function was completely wrong and mostly didn't do anything. Is some edge cases, it could maybe enable actuators, but as it stands pidff->device_control was treated like a field to assign values to, while it actually is an array with boolean fields.